Update: UltraVNC 1.4.3.6 and UltraVNC SC 1.4.3.6: viewtopic.php?t=37885
Important: Please update to latest version before to create a reply, a topic or an issue: viewtopic.php?t=37864

Join us on social networks and share our announcements:
- Website: https://uvnc.com/
- GitHub: https://github.com/ultravnc
- Mastodon: https://mastodon.social/@ultravnc
- Facebook: https://www.facebook.com/ultravnc1
- X/Twitter: https://twitter.com/ultravnc1
- Reddit community: https://www.reddit.com/r/ultravnc
- OpenHub: https://openhub.net/p/ultravnc

is Single Click not open source ?

Single Click discussions / bugs
Post Reply
ronan
8
8
Posts: 21
Joined: 2004-09-29 06:57
Location: France

is Single Click not open source ?

Post by ronan »

SC is just great, but I would like to access source code. I am not talking about the packaging tool created by Rudi (which is great and perfect for most people who can customize it without efforts and/or programming knowledge), but the source code of the light ultravnc server it embeds.

This would allow to tweak it a little more (either for specific needs, either for global improvements).

Moreover, speaking about such a sensitive tool, I'd rather know what it contains before using it in my company (no offense to development team, who is dedicated to us and who I trust, but just a wise concern in a professional environment).

I searched in CVS but was not able to find it. I asked this question a few times already within other topics with no success (no answer, I mean).
Is there a problem with sharing this specific part of the code ?

Regards,

Ronan
User avatar
pgmoney
100
100
Posts: 285
Joined: 2004-06-26 22:29
Contact:

Re: is Single Click not open source ?

Post by pgmoney »

ronan wrote: I searched in CVS but was not able to find it. I asked this question a few times already within other topics with no success (no answer, I mean).
Is there a problem with sharing this specific part of the code ?

Regards,

Ronan
It's in the RC19 source files, not a separate project...

#ifdef SINGLECLICKULTRA
User avatar
Rudi De Vos
Admin & Developer
Admin & Developer
Posts: 6839
Joined: 2004-04-23 10:21
Contact:

Post by Rudi De Vos »

SC was a code split RC19-3, to do it fast i just erase parts.

The problem is that i'm blocked for updates, the auto merging does not work.
The SC needs to be implemented as
#ifdef
#endif
in the general sourcecode.

This is already partly done, but was waiting for RC19 (stable)
to continue.
The manual cross check of all changed files is not done in 5 minutes, but #ifdef is the only way to keep it maintainable.

RC19 (stable) end december
SC in code tree january.
ronan
8
8
Posts: 21
Joined: 2004-09-29 06:57
Location: France

Post by ronan »

OK: silly me for not thinking it might already be there ! :-]

Thank you for your answer guys.

Actually, using conditional compilation is perfect for my needs. So to generate my customized SC version, I just need to add/uncomment a #define somewhere, or is there a specific project file as well ?

Regards,

Ronan
californiajeff
40
40
Posts: 101
Joined: 2004-12-22 23:19
Location: Las Vegas, NV
Contact:

Post by californiajeff »

where can I download source for RC19? I looked in CVS and it did not show source for RC 19. It did show it for RC 18 though...
User avatar
Rudi De Vos
Admin & Developer
Admin & Developer
Posts: 6839
Joined: 2004-04-23 10:21
Contact:

Post by Rudi De Vos »

As i told in the previous mail....

SC source will be implemented in the RC19 tree, but we have give priority to finish RC19. (only partly done)
As soon we have a stable RC19, the SC code will be added as
#define in the normal tree.

Current SC test was just a hack, code parts removed, added...
This way it is just impossible to keep the source up to date and
put all new fixes in it.
Guest

Post by Guest »

[quote="Rudi De Vos"]As soon we have a stable RC19, the SC code will be added as
#define in the normal tree.
[/quote]

I hope you know diff and patch!

diff -bruw ultravnc-RC18 ultravnc-SC > SC18
cp -r ultravnc-RC19 ultravnc-RC19+SC
patch -D SINGLECLICKULTRA -d ultravnc-RC19+SC -p1 < SC18

will do
#ifdef SINGLECLICKULTRA
// this is SC
#else
// this is VNC
#endif
User avatar
Rudi De Vos
Admin & Developer
Admin & Developer
Posts: 6839
Joined: 2004-04-23 10:21
Contact:

Post by Rudi De Vos »

Diff only works between
Orig code and SC and not between SC and the current cvs.....
All code changes in cvs after SC split are also considered as diffs but are actual bug fixes.

The only way is manual labor....
Anyway, a good time to cleanup and recheck some parts.

SC was just some tryout...if i would have known that people like it, all changes would have been added to cvs from start.
californiajeff
40
40
Posts: 101
Joined: 2004-12-22 23:19
Location: Las Vegas, NV
Contact:

Post by californiajeff »

Rudi De Vos wrote:Diff only works between
SC was just some tryout...if i would have known that people like it, all changes would have been added to cvs from start.
Single Click rulez!!! More ULtraVNC SC!!!
hardyx

I think SC must be a new project

Post by hardyx »

Hello Rudi,

Thanks for creating this easy version, is a great help for computer people and their friends !!!

In my oppinion the easy way is create a new project in sourceforge. You can name it UltraVNC SC or choose a different name if you like.

As you say, is based in VNC but you are removing and adding your own lines of code. There is a lot of changes in the UltraVNC source and it will be more in the future.

What do you think?
User avatar
Rudi De Vos
Admin & Developer
Admin & Developer
Posts: 6839
Joined: 2004-04-23 10:21
Contact:

Post by Rudi De Vos »

I'm current adding it via
#ifdef SC
#ifndef SC
(50% done)

A seperate project is to hard to maintain, merging with the
standard ultravnc, to import bug fixes does not work. Code
become unusable after merge :(

Better one tree with seperate compiler options
User avatar
Rudi De Vos
Admin & Developer
Admin & Developer
Posts: 6839
Joined: 2004-04-23 10:21
Contact:

SC added to cvs as

Post by Rudi De Vos »

SC added to cvs as
ultravnc/winvnc/winvncsc
(subproject of winvnc)
Post Reply