1.3.7 dev-4

Post Reply
Rudi De Vos
Admin & Developer
Admin & Developer
Posts: 6533
Joined: 2004-04-23 10:21
Contact:

1.3.7 dev-4

Post by Rudi De Vos »

https://www.uvnc.eu/download/1374/UltraVnc_1374.zip
https://www.uvnc.eu/download/1374/Ultra ... _Setup.exe
https://www.uvnc.eu/download/1374/Ultra ... _Setup.exe

Changes
installed has extra option to select only the start menu
[Setup]
...
Tasks=installservice,startservice,desktopicon,startmenu,associate,installdriver

reverted zip update, it breaks file transfer
SkyBeam
40
40
Posts: 119
Joined: 2012-12-31 11:01

Re: 1.3.7 dev-4

Post by SkyBeam »

Thanks a lot.

I did some tests and have some comments/results/annotations:
  • Start menu icons were not created. Neither with silent install (Tasks=starmenu) nor with interactive installation and checkbox selected (Desktop icon checkbox was unselected in
  • When selecting desktop icons to be created I am getting the following error: "Setup was unable to create the directory 'C:\ProgramData\Microsoft\Windows\Start Menu\Programs\UltraVNC'. Error 183: COnnot create a file when that file already exists." Even though the folder does not exist but
  • I noticed that since a while UVNC server includes the secure plugin. So no add-on installation needed any more. However when installing the viewer only it omits the secure plugin installation. I think the secure plugin should always also be installed also if only viewer is selected. Currently the only way to install the viewer only and getting the secure plugin is to install also the add-on package. But this is kind of useless as all components would be in the regular installer package. Alternatively it could be made optional with a task checkbox just like the display driver or icons. But the option should also be available for Viewer-only installation.
  • I confirm file transfers are working for me again in viewer 1.3.7 dev-4. I just transferred a folder with about 500MB successfully without the viewer crashing on creation of the ZIP.
I think the first and second item are related. I suspect some installer issue creating the UltraVNC start menu folder. Investigation on my machine has shown that somehow an empty file named UltraVNC (no extension) existed in my start menu folder. So yes, Windows is unable to create a folder with the same name as a file in the same folder (known limitation of Windows). Perhaps it would be advisable to check if 'C:\ProgramData\Microsoft\Windows\Start Menu\Programs\UltraVNC' exists and if it is a file (not a folder) remove it prior to deploying start menu icons. Such errors often happen if you try to copy a file to a folder which potentially does not exist at time of use. Eg.
copy c:\temp\some-shortcut.lnk "C:\ProgramData\Microsoft\Windows\Start Menu\Programs\UltraVNC"
This would leave a FILE called UltraVNC in the Programs folder in case the UltraVNC folder is not properly pre-created. This is why it would be better to use
copy c:\temp\some-shortcut.lnk "C:\ProgramData\Microsoft\Windows\Start Menu\Programs\UltraVNC\some-shortcut.lnk"
or validate the folder exists before copyign.

However, I have been unable to reproduce the issue and make the UVNC installer creating the file again. It might have been a glitch in any beta installers or even one of my own scripts. Hard to say. But the existence of the file prevented the installer from creating the icons permanently.
EDIT: Correction, I can reproduce the issue and it looks I should eat my own dogfood first. Actually found a code in my install scripts to copy a file to the UltraVNC folder. So when it does not exist it created a file called "UltraVNC" in Start Menu\Programs folder. Fixed my own code now. But others might have a similar issue. So I still recommend to check if there is a bare file called "UltraVNC" in start menu and remove it before deploying the icons.

Also I can confirm start menu icons are created if both options (desktop and start menu) are selected. But not if only start menu icons are selected. So I think there is some logic-issue in the installer. Both items should be independent.

I also never really understood what is the difference between the "UltraVNC Server" and "UltraVNC Server Silent" option. It seems to deploy the exact same files. Not even ultravnc.ini is different.


So here my recommended changes/fixes:
  • Make start menu icon creation independent form desktop icon creation (icons should deploy even if desktop icon option is not selected)
  • If C:\ProgramData\Microsoft\Windows\Start Menu\Programs\UltraVNC' exists and is a FILE, remove it to avoid issues deploying a start menu folder (perhaps check the code if it might under some circumstances cause such a file to be created).
  • Install encryption plugin component also if only viewer is installed.
SkyBeam
40
40
Posts: 119
Joined: 2012-12-31 11:01

Re: 1.3.7 dev-4

Post by SkyBeam »

I have found another slightly weird glitch/bug:

The new connect-notify feature does not work properly when not using mslogon2 authentication. When using the built-in authentication on server-side the notification message set on client side is ignored completely. The server does either just show the client ID/IP or (if configured to show a notification only when one is supplied by the client) does not show anything at all.

I can only suspect that this is due to some protocol negotiation and the notification message is only transferred when the code branch to support user/password authentication via mslogon2 is triggered. Not sure if this is a protocol limitation or just a bug. Is it possible to transfer a notification message as well in case the built-in VNC authentication is used?

In short:
  • Using mslogon2 authentication: InfoMsg is correctly shown.
  • Using built-in VNC authentication: InfoMsg is ignored.
Rudi De Vos
Admin & Developer
Admin & Developer
Posts: 6533
Joined: 2004-04-23 10:21
Contact:

Re: 1.3.7 dev-4

Post by Rudi De Vos »

Fixed some installer issue.
*Silent is not needed
*Upgrade is not needed

Plugins are installed with server/viewer
The menu is always installed, the desktop icons are optional ( like other installers do)

Only installers updated, code is still 1.3.7 dev 4

https://www.uvnc.eu/download/1374/Ultra ... _Setup.exe
https://www.uvnc.eu/download/1374/Ultra ... _Setup.exe

inno scripts
https://www.uvnc.eu/download/1374/Ultra ... ll_X86.iss
https://www.uvnc.eu/download/1374/Ultra ... ll_X64.iss
tiagocoelho2
Posts: 1
Joined: 2022-02-22 11:49

Re: 1.3.7 dev-4

Post by tiagocoelho2 »

Rudi De Vos wrote: 2022-02-17 19:55 https://www.uvnc.eu/download/1374/UltraVnc_1374.zip
https://www.uvnc.eu/download/1374/Ultra ... _Setup.exe
https://www.uvnc.eu/download/1374/Ultra ... _Setup.exe

Changes
installed has extra option to select only the start menu
[Setup]
...
Tasks=installservice,startservice,desktopicon,startmenu,associate,installdriver

reverted zip update, it breaks file transfer
Windows Server 2022 automatic installer. Driver.

Version 1.3.6.0 show "driver not compatible" message when installing silent mode, Windows Server 2022. This crashes the installer until you click "yes" and force driver installation. Has this been resolved in this version?
SkyBeam
40
40
Posts: 119
Joined: 2012-12-31 11:01

Re: 1.3.7 dev-4

Post by SkyBeam »

Here I fixed the download path if someone fails to download the latest version for testing: I can confirm the installer to work as intended. The silent installation does not require the Task=startmenu task any more, it will always and correctly deploy the start menu icons.
It is also properly installing the secure VNC plugin even if only viewer is selected as install option.
Also confusing "silent" options were removed. Now it looks really clean and polished.
I also like that the desktop icon creation option is UNchecked by default. Well done.

Concerning my issue that VNC Server does not display the notification message if built-in authentication is used rather than mslogon2: I do not expect changes here as binaries included did not change. So I did not test if this is fixed.

Many thanks!
VNCHELP890
20
20
Posts: 32
Joined: 2022-01-18 16:46

Re: 1.3.7 dev-4

Post by VNCHELP890 »

I never really paid attention. What WERE those "silent options", anyhow? Please remember, the simpler, the better.
SkyBeam
40
40
Posts: 119
Joined: 2012-12-31 11:01

Re: 1.3.7 dev-4

Post by SkyBeam »

VNCHELP890 wrote: 2022-02-23 00:12 I never really paid attention. What WERE those "silent options", anyhow? Please remember, the simpler, the better.
I also don't know. Perhaps it was legacy way to provide silent installation. However innosetup is allowing you to do an installation where choices are recorded to a file and you can use this file then to run the installation silently.

Just run:

Code: Select all

<setup>.exe /saveinf=response-file.inf

Then you can run a silent installation:

Code: Select all

<setup>.exe /verysilent /norestart /sp- /loadinf=response-file.inf
to run a completely silent deployment.

In latest setup the components list was cleaned up. So a full installation INF file might look as follows:

Code: Select all

[Setup]
Lang=en
Dir=C:\Program Files\uvnc bvba\UltraVNC
Group=UltraVNC
NoIcons=0
SetupType=full
Components=ultravnc_server,ultravnc_viewer,ultravnc_repeater
Tasks=installservice,startservice,installdriver
The tasks depend on the checkboxes you selected in regards of desktop icons and service installations. The components are related to the selected components (server, viewer, repeater) during setup.

Why there was a ultravnc_server_s component previously... I don't know and likely it was just some leftover from early days.
Rudi De Vos
Admin & Developer
Admin & Developer
Posts: 6533
Joined: 2004-04-23 10:21
Contact:

Re: 1.3.7 dev-4

Post by Rudi De Vos »

The new connect-notify feature does not work properly when not using mslogon2 authentication
Looks like some race condition.
Sometimes it works for both.. next test with same code only mslogon2.
Adding a sleep in the code it fail for both.
Post Reply